Sync recipes, run composer u and yarn upgrade, fix some deprecations #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyrixx
reviewed
Sep 30, 2021
HedicGuibert
force-pushed
the
recipes
branch
from
ff210ee
to
cc118f7
Compare
welcoMattic
reviewed
Sep 30, 2021
welcoMattic
reviewed
Sep 30, 2021
| @@ -46,14 +46,15 @@ | |||
| "symfony/phpunit-bridge": "^5.3", | |||
| "symfony/polyfill-uuid": "^1.20", | |||
| "symfony/process": "5.3.*", | |||
| "symfony/runtime": "5.3.*", | |||
There was a problem hiding this comment.
Why is it installed now?
There was a problem hiding this comment.
This is because of this PR : symfony/recipes@9a90e69
Symfony runtime is now a dependancy of the Symfony console.
There was a problem hiding this comment.
(An issue already exists : symfony/recipes#992)
HedicGuibert
force-pushed
the
recipes
branch
from
cc118f7
to
44d629f
Compare
HedicGuibert
force-pushed
the
recipes
branch
from
44d629f
to
c889d3b
Compare
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependancies and recipes where not completely up to date so this updates everything.
We still have a lot of deprecations however, beause of the
php-translationbundle, which is still using deprecated code.This should not be an issue anymore when we fix #221 (or when the library gets an update).